Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add I/O functions to simplify benchmarking #147

Merged
merged 7 commits into from
Jul 21, 2021

Conversation

HealthyPear
Copy link
Member

In the benchmarking notebooks, there are a lot of repeated functions to open and read files generated by protopipe

I will add here also utility functions to read files from ctapipe tools

@HealthyPear HealthyPear added enhancement New feature or request benchmarks input / output new features or issues regarding input and output formats labels Jun 16, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #147 (a121e16) into master (52faa69) will decrease coverage by 0.70%.
The diff coverage is 27.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   66.84%   66.14%   -0.71%     
==========================================
  Files          23       24       +1     
  Lines        2244     2283      +39     
==========================================
+ Hits         1500     1510      +10     
- Misses        744      773      +29     
Impacted Files Coverage Δ
protopipe/pipeline/io.py 23.33% <23.33%> (ø)
protopipe/pipeline/utils.py 55.49% <33.33%> (-1.41%) ⬇️
protopipe/pipeline/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52faa69...a121e16. Read the comment docs.

@HealthyPear HealthyPear marked this pull request as ready for review July 20, 2021 15:07
@HealthyPear HealthyPear requested a review from kosack July 20, 2021 15:07
@HealthyPear HealthyPear merged commit e1ce3e6 into master Jul 21, 2021
@HealthyPear HealthyPear deleted the add_io_functions_benchmarking branch July 21, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks enhancement New feature or request input / output new features or issues regarding input and output formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants