Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make progress bar optional and add it also to DL2 script #154

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

HealthyPear
Copy link
Member

In the case of a finite number of shower events, the GRID was killing the jobs due to the ASCII characters of the progress bar.

@HealthyPear HealthyPear added bug Something isn't working fix A PR that fixes a bug or a wrong behaviour. grid labels Jul 15, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #154 (de588cc) into master (2fe78fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   66.81%   66.84%   +0.02%     
==========================================
  Files          23       23              
  Lines        2242     2244       +2     
==========================================
+ Hits         1498     1500       +2     
  Misses        744      744              
Impacted Files Coverage Δ
protopipe/scripts/data_training.py 93.08% <100.00%> (+0.03%) ⬆️
protopipe/scripts/write_dl2.py 82.02% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe78fc...de588cc. Read the comment docs.

@HealthyPear HealthyPear merged commit 52faa69 into master Jul 20, 2021
@HealthyPear HealthyPear deleted the fix-make_progress_bar_optional branch July 20, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix A PR that fixes a bug or a wrong behaviour. grid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants