Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output NaN concentrations in case of HillasParameterizationError or similar #155

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

HealthyPear
Copy link
Member

This was causing crashes in rare cases

@HealthyPear HealthyPear added bug Something isn't working fix A PR that fixes a bug or a wrong behaviour. input / output new features or issues regarding input and output formats labels Jul 15, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #155 (2c8140a) into master (845189c) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   66.93%   66.81%   -0.12%     
==========================================
  Files          23       23              
  Lines        2238     2242       +4     
==========================================
  Hits         1498     1498              
- Misses        740      744       +4     
Impacted Files Coverage Δ
protopipe/pipeline/event_preparer.py 65.17% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845189c...2c8140a. Read the comment docs.

@HealthyPear HealthyPear merged commit 2fe78fc into master Jul 20, 2021
@HealthyPear HealthyPear deleted the fix-output-nan-concentration branch July 20, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix A PR that fixes a bug or a wrong behaviour. input / output new features or issues regarding input and output formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants