Improve data scripts output and update analysis default settings #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract the number of reconstructed images per telescope type - record pixels number in a better way - allow for peak-time and waveform shifts - improve wavelets import error - remove stale code
- record number of reconstructed images per telescope type - record true direction and array pointing - add metadata
- add number of reconstructed images per telescope type - add metadata - fix default output values and some formatting
HealthyPear
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 66.65% 74.26% +7.61%
==========================================
Files 24 22 -2
Lines 2600 2320 -280
==========================================
- Hits 1733 1723 -10
+ Misses 867 597 -270
Continue to review full report at Codecov.
|
Remove stale code and apply some PEP8 formatting
Remove unused imports from pywi-cta and import warning, now dealt with when initializing EventPreparer
This was referenced Jan 25, 2022
2 tasks
- better handling of missing pywi(-cta) - get cameras' radii from ctapipe - added SST_ASTRI_CHEC - PEP8 formatting
- I/O refactoring - camera radii from ctapipe - CLI improvements - added support for Prod5b Paranal with NectarCam - PEP8 formatting
- I/O refactoring - PEP8 formatting
- improve configuration - PEP8 formatting
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- allow for separate particle type folders - improve CLI checks
kosack
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
List of changes
gammapy==0.18.2,pyirf ==0.5.0,pandas >=1.0.0model diagnosticsscript and API will migrate frommvatobenchmarks