Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prod5N files #167

Merged

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Oct 4, 2021

This PRs allows for input checking and initialization of the required quantities from files belonging to Prod5 or Prod5b productions.

Closes #60

Support for integration tests will be added later.

@HealthyPear HealthyPear added enhancement New feature or request pipeline applications Application of the pipeline to specific studies input / output new features or issues regarding input and output formats labels Oct 4, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #167 (740d495) into master (fc277c3) will decrease coverage by 0.73%.
The diff coverage is 45.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   66.85%   66.11%   -0.74%     
==========================================
  Files          24       24              
  Lines        2359     2402      +43     
==========================================
+ Hits         1577     1588      +11     
- Misses        782      814      +32     
Impacted Files Coverage Δ
protopipe/pipeline/utils.py 49.26% <32.72%> (-6.23%) ⬇️
protopipe/scripts/write_dl2.py 81.11% <61.90%> (-1.15%) ⬇️
protopipe/scripts/data_training.py 92.10% <64.70%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc277c3...740d495. Read the comment docs.

protopipe/pipeline/utils.py Outdated Show resolved Hide resolved
@HealthyPear HealthyPear marked this pull request as ready for review January 24, 2022 18:50
@HealthyPear HealthyPear merged commit 0a7495f into cta-observatory:master Feb 1, 2022
@HealthyPear HealthyPear deleted the feature-add_support_for_prod5 branch February 1, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request input / output new features or issues regarding input and output formats pipeline applications Application of the pipeline to specific studies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Prod5
2 participants