-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for prod5N files #167
Merged
HealthyPear
merged 9 commits into
cta-observatory:master
from
HealthyPear:feature-add_support_for_prod5
Feb 1, 2022
Merged
Add support for prod5N files #167
HealthyPear
merged 9 commits into
cta-observatory:master
from
HealthyPear:feature-add_support_for_prod5
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow for use of Prod5 array selection - improve checks from analysis configuration file
HealthyPear
added
enhancement
New feature or request
pipeline applications
Application of the pipeline to specific studies
input / output
new features or issues regarding input and output formats
labels
Oct 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 66.85% 66.11% -0.74%
==========================================
Files 24 24
Lines 2359 2402 +43
==========================================
+ Hits 1577 1588 +11
- Misses 782 814 +32
Continue to review full report at Codecov.
|
kosack
reviewed
Oct 11, 2021
…althyPear/protopipe into feature-add_support_for_prod5
kosack
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
input / output
new features or issues regarding input and output formats
pipeline applications
Application of the pipeline to specific studies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs allows for input checking and initialization of the required quantities from files belonging to Prod5 or Prod5b productions.
Closes #60
Support for integration tests will be added later.