Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly count SSTs, MSTs, and LSTs. #184

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Apr 1, 2022

changes write_dl2 and training script to count SSTs (and MSTs and LSTs) in a more general manner.

fixes #178

@kosack kosack requested a review from HealthyPear as a code owner April 1, 2022 09:57
protopipe/scripts/data_training.py Outdated Show resolved Hide resolved
protopipe/scripts/write_dl2.py Outdated Show resolved Hide resolved
@HealthyPear HealthyPear added fix A PR that fixes a bug or a wrong behaviour. wrong behaviour The code works but produces clearly wrong results labels Apr 1, 2022
@HealthyPear HealthyPear added this to the v0.5.0 milestone Apr 1, 2022
@HealthyPear
Copy link
Member

also, N_reco_SST is missing from data_training.py here

N_reco_MST=tb.Int16Col(dflt=-1, pos=64),

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #184 (16ab0b5) into master (1f392ea) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   63.05%   63.06%   +0.01%     
==========================================
  Files          28       28              
  Lines        2885     2886       +1     
==========================================
+ Hits         1819     1820       +1     
  Misses       1066     1066              
Impacted Files Coverage Δ
protopipe/scripts/data_training.py 91.86% <100.00%> (+0.03%) ⬆️
protopipe/scripts/write_dl2.py 80.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f392ea...16ab0b5. Read the comment docs.

@kosack kosack merged commit 9c0932c into cta-observatory:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A PR that fixes a bug or a wrong behaviour. wrong behaviour The code works but produces clearly wrong results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of recorded SST telescopes is miscalculated or missing
2 participants