-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added versioning to init.py and setup.py using the manual approach. #20
Merged
HealthyPear
merged 2 commits into
cta-observatory:master
from
HealthyPear:feature-update_version
Nov 8, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
__version__ = "0.2.1-dev" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,21 @@ | ||
from setuptools import setup, find_packages | ||
from protopipe import __version__ | ||
|
||
|
||
def readme(): | ||
with open('README.rst') as f: | ||
with open("README.rst") as f: | ||
return f.read() | ||
|
||
setup(name='protopipe', | ||
version='0.1', | ||
description='Pipeline to process events from DL0 to DL3', | ||
url='http://github.com/jjlk/protopipe', | ||
author='CEA', | ||
author_email='[email protected]', | ||
license='MIT', | ||
packages=find_packages(), | ||
install_requires=['ctapipe'], | ||
zip_safe=False) | ||
|
||
setup( | ||
name="protopipe", | ||
version=__version__, | ||
description="Pipeline to process events from DL0 to DL3", | ||
url="https://github.com/cta-observatory/protopipe", | ||
author="Michele Peresano, Karl Kosack, Thierry Stolarczyk, Alice Donini, Thomas Vuillaume", | ||
author_email="[email protected]", | ||
license="MIT", | ||
packages=find_packages(), | ||
install_requires=["ctapipe"], | ||
zip_safe=False, | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually "0.y.z" already states "dev" no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert on this: this "dev" means that is the development version after the tagging of the last release (the docs will be built from the master branch as for ctapipe, which code to get the version is a bit complicated for me now.).
I have seen people using "-alpha", "-beta", but I didn't want to be overly specific for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this case, "dev" means "not a tagged release"