Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate RAD_MAX tables #180

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Interpolate RAD_MAX tables #180

merged 4 commits into from
Oct 31, 2022

Conversation

RuneDominik
Copy link
Member

This adds an interpolation function for point-like IRF'S RAD_MAX table. Interpolation is done linearly through scipy's griddata.

* Added interpolate_rad_max as wrapper around scipy.interpolate.griddata
* Added doc-string
* Added function to __all__
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Base: 90.73% // Head: 90.79% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (f0be0dc) compared to base (285bca1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   90.73%   90.79%   +0.06%     
==========================================
  Files          41       40       -1     
  Lines        1598     1663      +65     
==========================================
+ Hits         1450     1510      +60     
- Misses        148      153       +5     
Impacted Files Coverage Δ
pyirf/interpolation.py 93.05% <100.00%> (+0.19%) ⬆️
pyirf/tests/test_interpolation.py 100.00% <100.00%> (ø)
pyirf/io/eventdisplay.py 28.00% <0.00%> (-7.00%) ⬇️
pyirf/cut_optimization.py 0.00% <0.00%> (ø)
pyirf/tests/test_binning.py 100.00% <0.00%> (ø)
pyirf/tests/test_spectral.py 100.00% <0.00%> (ø)
pyirf/tests/test_sensitivity.py 100.00% <0.00%> (ø)
pyirf/benchmarks/angular_resolution.py 100.00% <0.00%> (ø)
pyirf/benchmarks/tests/test_angular_resolution.py 100.00% <0.00%> (ø)
pyirf/__init__.py
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pyirf/interpolation.py Outdated Show resolved Hide resolved
@maxnoe
Copy link
Member

maxnoe commented Oct 18, 2022

@RuneDominik Happy to merge this if you add a unit test.

@maxnoe maxnoe merged commit 610b864 into cta-observatory:master Oct 31, 2022
@RuneDominik RuneDominik deleted the RadMaxInterpolation branch April 19, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants