Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize edisp to integral of 1, not sum of 1 #250

Merged
merged 15 commits into from
Aug 23, 2023

Address review comments

1164644
Select commit
Loading
Failed to load commit list.
Merged

Normalize edisp to integral of 1, not sum of 1 #250

Address review comments
1164644
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 22, 2023 in 0s

99.35% of diff hit (target 94.73%)

View this Pull Request on Codecov

99.35% of diff hit (target 94.73%)

Annotations

Check warning on line 691 in pyirf/interpolation/component_estimators.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pyirf/interpolation/component_estimators.py#L691

Added line #L691 was not covered by tests

Check warning on line 15 in pyirf/interpolation/utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pyirf/interpolation/utils.py#L15

Added line #L15 was not covered by tests