-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start working on fixing interpolation for fixed edisp #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuneDominik
reviewed
Aug 21, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## fix_edisp_normalization #251 +/- ##
===========================================================
+ Coverage 94.74% 94.76% +0.02%
===========================================================
Files 60 60
Lines 2985 3040 +55
===========================================================
+ Hits 2828 2881 +53
- Misses 157 159 +2
☔ View full report in Codecov by Sentry. |
maxnoe
added
the
no-changelog-needed
Minor change, no newsfragment/changelog needed
label
Aug 22, 2023
maxnoe
commented
Aug 22, 2023
…lue != 0 in moment morphing
RuneDominik
approved these changes
Aug 22, 2023
Going on in #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RuneDominik This is a PR targeting #250 with changes related to the interpolation code.
I started this during ICRC and will have a look now again, I don't remember quite how far I got, please have a look and maybe just push here any changes you might want to include to make it work