Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

don't link with Octave libs on GNU/Linux #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtmiller
Copy link
Collaborator

@mtmiller mtmiller commented Jan 8, 2020

Drop rustc-link-lib options on x86_64-unknown-linux-gnu. Duplicate target-dependent link logic into helloworld.

Closes #55.

@mtmiller
Copy link
Collaborator Author

mtmiller commented Jan 8, 2020

Hmm, I don't really understand the build system. I want to remove the rustc-link-lib options when building oct files, but that breaks cargo test. If I add the options back in octh/build.rs only, they also seem to apply when building oct files. I'm not sure how these pieces fit together. Happy to learn, pointers welcome!

@ctaggart
Copy link
Owner

ctaggart commented Jan 8, 2020

May be try the workaround here:
rust-lang/cargo#2549

if cfg!(feature="test") { ... }

And then run with cargo test --features=test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't link extensions with liboctave and liboctinterp
2 participants