Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(why not use this repo as a testing ground for sourmash-bio/sourmash#696 and sourmash-bio/sourmash#680? 😺 )
Dev dependency installation becomes
pip install tox
(or, even better,pipx install tox
). Tests, checks, coverage upload... all tasks are executed bytox
, which also takes care of setting up virtualenvs.Linting and code formatting are executed by
pre-commit
, which can be installed (using thetox
venvs) to be executed every time a new commit is made. This makes sure that new commits follow a formatting standard, and avoid adding common errors.At the end of
tox -e fix_lint
execution there are instructions on how to set uppre-commit
.I tried to keep commits independent, so they can be dropped individually:
setup.py
intopyproject.toml
, and usesflit
for packaging.black
andflake8
flake8
and fix detected errorsblack
, the code autoformatter.