Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #240

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Fix #240

merged 1 commit into from
Oct 11, 2018

Conversation

realtebo
Copy link
Contributor

@realtebo realtebo commented Jul 5, 2018

See my own Isse opened here googlearchive/cloud-functions-emulator#173

In the thread, the suggested fix point to this: googlearchive/cloud-functions-emulator#173

So i'm opening you a PR

@realtebo
Copy link
Contributor Author

realtebo commented Jul 5, 2018 •
edited
Loading

LOL ... someone loose its time to propose a fix and you're using cretaceus node versions in the CI ...

From Travis log of failure

$ node --version
v4.9.1
$ npm --version
2.15.11

@cthackers cthackers merged commit 74bdec6 into cthackers:master Oct 11, 2018
@teppeis teppeis mentioned this pull request Nov 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realtebo @cthackers