Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong indentation if column comments are in cyrillic (non-latin?) #675

Closed
khataev opened this issue Oct 18, 2019 · 1 comment · Fixed by #676
Closed

Wrong indentation if column comments are in cyrillic (non-latin?) #675

khataev opened this issue Oct 18, 2019 · 1 comment · Fixed by #676

Comments

@khataev
Copy link

khataev commented Oct 18, 2019

Commands

$ bundle exec rake annotate_models

Version

  • annotate version 3.0.2
  • rails version 6.0.0
  • ruby version 2.6.5

I'm using postgres db with pg gem 1.1.4

Annotate create wrong indentation when column comment is cyrillic (perhaps issue for any non-latin language), compare:

pure latin
pure latin

with cyrillic symbols
with cyrillic symbols
sashabelozerov added a commit to sashabelozerov/annotate_models that referenced this issue Oct 26, 2019
@sashabelozerov
[Fix ctran#675] Correct indentation for double-byte characters
33d6623
sashabelozerov added a commit to sashabelozerov/annotate_models that referenced this issue Oct 26, 2019
@sashabelozerov
[Fix ctran#675] Correct indentation for double-byte characters
538642e
@sashabelozerov sashabelozerov mentioned this issue Oct 26, 2019
Merged
@ctran ctran closed this as completed in #676 Nov 9, 2019
ctran pushed a commit that referenced this issue Nov 9, 2019
@sashabelozerov @ctran
[Fix #675] Correct indentation for double-byte characters (#676)
1df2153
@khataev
Copy link
Author

khataev commented Nov 22, 2019

Downloaded new version of annotate gem (3.0.3), but nothing changed... I ran rake task
be rake annotate_models

peterfication pushed a commit to store2be/annotate_models that referenced this issue Jan 20, 2020
@sashabelozerov @peterfication
[Fix ctran#675] Correct indentation for double-byte characters (ctran…
60b955e 
…#676)
vfonic pushed a commit to vfonic/annotate_models that referenced this issue May 8, 2020
@sashabelozerov @vfonic
[Fix ctran#675] Correct indentation for double-byte characters (ctran…
d03b9f5 
…#676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #675] Correct indentation for double-byte characters sashabelozerov/annotate_models
1 participant
@khataev