-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional file patterns cli #636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwjackson
force-pushed
the
additional_file_patterns_cli
branch
from
July 10, 2019 19:51
7c6044c
to
7c66fe9
Compare
@drwl Nevermind. Rebased and updated the new parser and added a test. |
@ryanwjackson looks like there's a merge conflict. Would you mind resolving it? I can merge this in and #637 after. |
ryanwjackson
force-pushed
the
additional_file_patterns_cli
branch
from
August 6, 2019 10:01
e5ae9bd
to
1f2d419
Compare
@drwl Rebased this and the docs branch. |
drwl
pushed a commit
that referenced
this pull request
Aug 8, 2019
peterfication
pushed a commit
to store2be/annotate_models
that referenced
this pull request
Jan 20, 2020
Adds option for additional file patterns (implemented in ctran#633) in the CLI.
peterfication
pushed a commit
to store2be/annotate_models
that referenced
this pull request
Jan 20, 2020
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Adds option for additional file patterns (implemented in ctran#633) in the CLI.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drwl I created a separate PR for the CLI argument, just in case. Are there any tests for the CLI?