Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert documentation files to Markdown #697

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

Vasfed
Copy link
Contributor

@Vasfed Vasfed commented Dec 5, 2019

This fixes #684

Also added notice about somewhat breaking change in 3.0 about models not being annotated by default when no option in config

@Vasfed
Copy link
Contributor Author

Vasfed commented Dec 5, 2019

Looks like github action is broken in master, travis build succeeded

@drwl
Copy link
Collaborator

drwl commented Dec 16, 2019

@Vasfed thanks for this. Let me try and investigate what's going wrong in CI

@drwl
Copy link
Collaborator

drwl commented Dec 17, 2019

@Vasfed I fixed CI issues in #698, can you rebase?

@Vasfed
Copy link
Contributor Author

Vasfed commented Dec 17, 2019

@drwl rebased, all is ok now

Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking this on and also adding the bit about the breaking version 3 change to CHANGELOG. It's really appreciated 👍.

@drwl drwl merged commit cb09e6a into ctran:develop Dec 17, 2019
@drwl drwl added the reviewed label Dec 17, 2019
peterfication pushed a commit to store2be/annotate_models that referenced this pull request Jan 20, 2020
* Convert documentation files to Markdown
* Add notice about models not being annotated by default to changelog in 3.0
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
* Convert documentation files to Markdown
* Add notice about models not being annotated by default to changelog in 3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from rdoc to markdown
2 participants