Rename method and variable of AnnotateRoutes for readability #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Routes.remove_annotations
…Routes.rewrite_contents_with_header
…Routes.annotate_routes
…Routes.strip_on_removal
…tes.real_content_and_header_position
…tes.strip_annotations
drwl
approved these changes
Jan 6, 2020
nard-tech
deleted the
feature/refactor_annotate_routes/rename_variables
branch
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Before I commited, the method `AnnotateRoutes.where_header_found` returned an array of `real_content` and `header_found_at`. I fixed the name of method and variable because they did not match. I renamed the method `real_content_and_header_position` and unified related variable names to `header_position`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I commited, the method
AnnotateRoutes.where_header_foundreturned an array ofreal_contentandheader_found_at.I fixed the name of method and variable because they did not match.
I renamed the method
real_content_and_header_positionand unified related variable names toheader_position.