Add constants MAGIC_COMMENT_MATCHER #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nard-tech
force-pushed
the
feature/add-constants-magic-comment-matcher
branch
from
e11aaac
to
59f11d9
Compare
|
The Regexp in AnnotateModels and that in AnnotateRoutes are different. Is it OK? I think that |
@nard-tech It should be okay that they're different for the time being. I think without better test coverage we shouldn't make behavior changes. |
drwl
approved these changes
Jan 15, 2020
All right. Thank you for your reply. |
nard-tech
added a commit
to nard-tech/annotate_models
that referenced
this pull request
Jan 16, 2020
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
I added `AnnotateModels::MAGIC_COMMENT_MATCHER` and `AnnotateRoutes::MAGIC_COMMENT_MATCHER` instad of `AnnotateModels.magic_comment_matcher` and `AnnotateRoutes.magic_comment_matcher`. I think that they should be constants because the result of Regexp is always fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
AnnotateModels::MAGIC_COMMENT_MATCHERandAnnotateRoutes::MAGIC_COMMENT_MATCHERinstad ofAnnotateModels.magic_comment_matcherandAnnotateRoutes.magic_comment_matcher.I think that they should be constants because the result of Regexp is always fixed.