Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AnnotateRoutes.remove_annotations #715

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Refactor AnnotateRoutes.remove_annotations #715

merged 2 commits into from
Jan 16, 2020

Conversation

nard-tech
Copy link
Collaborator

@nard-tech nard-tech commented Jan 8, 2020 •
edited
Loading

I refactored AnnotateRoutes.remove_annotations.

Summary

  • Build new_text in .remove_annotations
  • Add trailing new line in .strip_on_removal
  • Use .rewrite_contents for comparing existing_text and new_text, and write new_text to the file.

@nard-tech
Copy link
Collaborator Author

I will refactor and finally remove AnnotateRoutes.rewrite_contents_with_header in another PR because it is similar to .rewrite_contents.

@drwl drwl merged commit 966bff0 into ctran:develop Jan 16, 2020
@nard-tech nard-tech deleted the feature/refactor_annotate_routes/remove_annotations branch January 17, 2020 10:20
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
@nard-tech @vfonic
Refactor AnnotateRoutes.remove_annotations (ctran#715)
851b0e7 
* Refactor AnnotateRoutes.rewrite_contents and .remove_annotations

* Refactor AnnotateRoutes.remove_annotations and .strip_on_removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwl drwl drwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nard-tech @drwl