Refactor AnnotateRoutes.routes_file_exist? #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nard-tech this may have gotten into merge conflict from the other PRs. Can you rebase and tag me? |
|
@drwl I'm sorry to trouble you. I fixed conflict. |
nard-tech
deleted the
feature/refactor_annotate_routes/routes_file_exist
branch
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
I refactored `AnnotateRoutes.routes_exists?` and methods using this. The points are as follows. * Removing `puts` in `AnnotateRoutes.routes_exists?` * Using `File.exist?` instead of `File.exists?` because `File.exists?` is deprecated * Renaming `AnnotateRoutes.routes_exists?` to `AnnotateRoutes.routes_file_exists?` in order to make the name of method more explanatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored
AnnotateRoutes.routes_exists?and methods using this.The points are as follows.
putsinAnnotateRoutes.routes_exists?File.exist?instead ofFile.exists?becauseFile.exists?is deprecatedAnnotateRoutes.routes_exists?toAnnotateRoutes.routes_file_exists?in order to make the name of method more explanatory