Refactor namespace Annotate #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
requested changes
Jan 15, 2020
| @@ -136,4 +131,13 @@ def self.bootstrap_rake | |||
| load_tasks | |||
| Rake::Task[:set_annotation_options].invoke | |||
| end | |||
|
|
|||
| class << self | |||
There was a problem hiding this comment.
This seems interesting, I'm not sure I've seen this before. Could you explain what is supposed to be happening?
Seems like a module that has class-level methods. But I'm confused as to what happens when doing the
class << self
...
endin a module
There was a problem hiding this comment.
@drwl when you want to defined private method, you can write like this.
cf. https://stackoverflow.com/questions/4952980/how-to-create-a-private-class-method/12311586#12311586
drwl
approved these changes
Jan 16, 2020
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
* Remove Annotate.#loaded_tasks= and .loaded_tasks * Remove unnecessary comment for Rubocop * Make Annotate.load_requires private * Refactor Annotate.load_tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Annotate.loaded_tasks=andAnnotate.loaded_tasksAnnotate.load_tasks