Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revert #677] Fix column default annotations #768

Merged
merged 4 commits into from
Mar 8, 2020
Merged

Conversation

drwl
Copy link
Collaborator

@drwl drwl commented Feb 29, 2020

It was reported in #762 that column defaults were broken. This reverts changes made in #677 to restore the expected behavior of column defaults.

For the time being columns with associated enums won't be working.

@paul
Copy link

paul commented Mar 3, 2020

I've confirmed this fixes the issue described in #762 in our application. Thanks!

@erikkessler1
Copy link
Contributor

@drwl any sense of when this will be released?

@drwl drwl merged commit 57ec388 into develop Mar 8, 2020
@drwl drwl deleted the drwl/revert-677 branch March 8, 2020 23:02
@drwl
Copy link
Collaborator Author

drwl commented Mar 9, 2020

@erikkessler1 I tried releasing it yesterday but there's an issue with our gem publish release workflow. Hopefully tonight, but looking to do it this week at the latest.

@erikkessler1
Copy link
Contributor

Sounds good @drwl. Thank you for the update!

vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
It was reported in ctran#762 that column defaults were broken. This reverts changes made in ctran#677 to restore the expected behavior of column defaults. 

For the time being columns with associated enums won't be working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants