[WIP] Fix updating annotation when formatted for Yard docs #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lgoic in `AnnotateModels.annotate_one_file` for determining whether there were changes a class' list of columns relied on a `column_pattern` regular expression to fetch the list of columns in the annotation. This regular expression was hard-coded to match on the original, default "bare" syntax. If using an alternative documentation format (e.g., Yard), this regular expression would fail to find the columns and not attempt to update the class' annoations. This adds an additional regular expression to search for Yard-formatted documentation.
|
Closed in favor of #784 to leverage GitHub's Draft PR feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP attempt to resolve #780
I'd be interested in feedback on the direction of the approach.
TODO: