Split on cert filenames #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed $filename to $full_filename Added a split on this this value to separate the different paths that might be listed within the certificate's filename (based on a comma). Then added a loop to run through each path and treat it as a separate certificate filename. This allows certificates to be saved into multiple location/files by using a comma separated list in the filename field
|
Thanks Oliver, looks good. Can you just fix the indenting please for the new loop? Also, it would be worth doing |
|
Thanks Oliver, merged and deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed $filename to $full_filename
Added a split (on comma) to this this value to separate the different paths that might be listed within the certificate's filename.
Then added a loop to run through each path and treat it as a separate certificate filename.
This allows certificates to be saved into multiple location/files by using a comma separated list in the filename field.