Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Partitioned index filter test #4544

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cristipp
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#3777

Description of Changes Made (if issue reference is not provided)

Adds a test for left join + where for 2 tables backed by a partitioned index.

@cristipp cristipp requested a review from a team as a code owner May 17, 2022 00:05
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #4544 (7605e42) into master (e59d2fb) will decrease coverage by 12.04%.
The diff coverage is n/a.

❗ Current head 7605e42 differs from pull request most recent head 99ef648. Consider uploading reports for the commit 99ef648 to get more accurate results

@@             Coverage Diff             @@
##           master    #4544       +/-   ##
===========================================
- Coverage   71.29%   59.24%   -12.05%     
===========================================
  Files         247      136      -111     
  Lines       25270    11109    -14161     
  Branches     2741     2741               
===========================================
- Hits        18016     6582    -11434     
+ Misses       6750     4023     -2727     
  Partials      504      504               
Flag Coverage Δ
cube-backend 59.24% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ngine/information_schema/postgres/pg_constraint.rs
...besql/cubesql/src/compile/rewrite/rules/filters.rs
...gine/information_schema/postgres/character_sets.rs
rust/cubesql/cubesql/src/sql/server_manager.rs
...engine/information_schema/postgres/pg_namespace.rs
rust/cubesql/cubesql/e2e/tests/postgres.rs
...ile/engine/information_schema/postgres/pg_range.rs
...esql/cubeclient/src/models/v1_cube_meta_segment.rs
.../compile/engine/information_schema/mysql/tables.rs
rust/cubesql/cubesql/src/transport/ext.rs
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59d2fb...99ef648. Read the comment docs.

@rpaik rpaik removed the pr:community Contribution from Cube.js community members. label May 20, 2022
@paveltiunov paveltiunov requested a review from a team as a code owner November 5, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants