fix(cubesql): Allow aggregation pushdown only for unlimited CubeScan #8929
+155
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8929 +/- ##
==========================================
+ Coverage 82.66% 82.69% +0.03%
==========================================
Files 221 221
Lines 78303 78438 +135
==========================================
+ Hits 64726 64865 +139
+ Misses 13577 13573 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KSDaemon
reviewed
Nov 8, 2024
mcheshkov
force-pushed
the
deny-aggregation-over-limit
branch
3 times, most recently
from
b5fc0e4
to
afa5daa
Compare
mcheshkov
force-pushed
the
deny-aggregation-over-limit
branch
from
afa5daa
to
f9925b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Aggregate(CubeScan(limit=n))is not equivalent toCubeScan(aggregation, limit=n)Former does aggregation over first n rows, latter returns first n rows after aggregation.