refactor(cubesql): Improve EGraph debugger, part 3: parsing and data preparation in UI side #8934
+319
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8934 +/- ##
==========================================
+ Coverage 82.66% 82.72% +0.06%
==========================================
Files 221 221
Lines 78303 78244 -59
==========================================
+ Hits 64726 64728 +2
+ Misses 13577 13516 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KSDaemon
approved these changes
Nov 8, 2024
| @@ -18,6 +18,7 @@ import type { | |||
| NodeProps, | |||
| } from 'reactflow'; | |||
| import 'reactflow/dist/style.css'; | |||
| import { z } from 'zod'; | |||
There was a problem hiding this comment.
Probably, not a big deal but still:
We already have a joi scheme validator in our codebase, so maybe we can reuse it here too? I know, node_modules is a black hole and could hold any number of packages) but... If we can reduce and reuse...Why not?
Used just for Id for now
mcheshkov
force-pushed
the
refactor-egraph-debugger-3
branch
from
676b716
to
5212ee8
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Add proper parsing on UI side, to catch data format changes.
Move most of data preparation related to UI (like a concepts of edge or combo) to UI completely, simplify data collection on rewriter side.