[gherkin perl] general cleanup by upgrading the Perl dependency #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to close the file in the DESTROY method, because the file is closed as soon as the file descriptor goes out of scope (which is what triggers the DESTROY call too).
5.12.0 was released Apr 12, 2010.
Note that the new `Encode` dependency is a core module, which means it's a dependency, but it's not external. Therefore, it doesn't need to be declared as such in the 'cpanfile'.
ehuelsmann
added
library: gherkin
language: perl
🤖 dependencies
The Perl ecosystem slowly moves from Test::More to Test2. The latter is better architected and has many, many more options for state validation out of the box.
Make sure the token scanner doesn't skip empty lines and strips carriage returns as intended.
|
@ehuelsmann is this PR ready to be merged? |
|
@aurelien-reeves yes, it is. I was waiting for an answer to the effect on version numbering; @olleolleolle explained that upping the minimum version should be only a minor version upgrade. So, lets merge! |
|
Merging with the implied consent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Miscelaneous cleanup made possible after upgrading the Perl minimum requirement to 5.12.0 (which was released in April 2010).
Details
IO::Scalar) by taking advantage of that.IO::File, which removes the need to explicitly load and createIO::Fileinstances.Motivation and Context
The resulting code is overall more clean and more modern Perl.
How Has This Been Tested?
The test suite runs on this change as expected.
Types of changes
Checklist: