Changes for frozen string literals #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the build failures are anything you've done. More likely something to do with #103. |
|
Maybe it would have been better not to merge #103 as it did not updated the tests it broke |
|
Agreed - my bad. I didn't notice it had broken anything when I merged it. |
|
How can we improve the CI notification so you're less likely to miss out on build errors @mattwynne? |
|
I'm puzzled why I didn't see the Travis check in the PR. There was something weird about that PR. NM - it's not a big deal to fix. |
|
Thanks @twalpole - immutability FTW! 👍 |
mattwynne
added a commit
that referenced
this pull request
Jul 1, 2016
mattwynne
added a commit
to cucumber/cucumber-ruby
that referenced
this pull request
Jul 2, 2016
CyrilPatrice
pushed a commit
to PagesjaunesMobile/cucumber-ruby-core
that referenced
this pull request
Feb 1, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates for compatibility with frozen string literals