Add Result#non_zero_exit_status? #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2015
|
The name here seems very coupled to a command-line UI. How about just having an |
|
The naming is the hard part here. When the 5-6 result types shall be mapped to the binary "yes/no", "true/false", "1/0" what should the name be? "Passed/Failed" feel intuitively right, but wait it is already taken to mean something else. I am ok with |
This could simplify logic where Pending and Undefined results in strict mode shall be handled in the same way as Failed results.
mattwynne
force-pushed
the
result-non-zero-exit-status
branch
from
22e6a87
to
26f79d6
Compare
|
I made the executive decision to use my preferred name :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could simplify logic where Pending and Undefined results in strict mode shall be handled in the same way as Failed results.
The first to use it is the JUnit Formatter (cucumber/common#855)