Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Ruby 1.9.3 and below #902

Closed
mattwynne opened this issue Aug 7, 2015 · 7 comments · Fixed by #993
Closed

Remove support for Ruby 1.9.3 and below #902

mattwynne opened this issue Aug 7, 2015 · 7 comments · Fixed by #993
Assignees
Milestone

Comments

@mattwynne
Copy link
Member

Any objections?

@mattwynne mattwynne added this to the 3.0 milestone Aug 7, 2015
@akostadinov
Copy link
Contributor

Depends on when 3.0 is going to be released. We have an older test suite that's perhaps going to live for another 2 years. I guess it wont need new features though so even if 3.0 is released in the following months, I guess 2.x would be solid enough to have it going long enough.

@tooky
Copy link
Member

tooky commented Aug 7, 2015

It's worth noting that 1.9.3 has been end of lifed, so it's no longer supported by Ruby.

@akostadinov
Copy link
Contributor

akostadinov commented Aug 7, 2015 via email

@mattwynne
Copy link
Member Author

@myronmarston what are your thoughts on this? You need Cucumber in order to run your test suite, right? How long are you going to keep supporting old Rubies?

@myronmarston
Copy link

@myronmarston what are your thoughts on this? You need Cucumber in order to run your test suite, right? How long are you going to keep supporting old Rubies?

RSpec is still on cucumber 1.x because we still support 1.8.7, 1.9.2, 1.9.3, and all 2.x versions. In general:

  • We treat the supported ruby versions as part of SemVer, meaning the only time we drop support for old versions is when a new major RSpec version comes out.
  • We don't like putting gem authors in the position of having to choose between dropping support for an old ruby version before they are ready (in order to upgrade RSpec) or staying on an old RSpec version, so we support old versions long after the ruby core team has stopped supporting them. This is particularly important for some gems like bundler, which still supports 1.8.7 and 1.9.2 and uses RSpec.

In RSpec 4, we will definitely drop support for 1.8.7, and perhaps 1.9.2 and 1.9.3 (although that's much less likely).

It looks like cucumber 2.x only supports 1.9.3+, right? So I guess we are going to be stuck on cucumber 1.x for the foreseeable future. Honestly, we haven't had any cucumber pain points that have encouraged us to upgrade, anyway. Hopefully cucumber 1.x will continue working with new ruby versions (e.g. 2.3)? We might get in a bind if changes in ruby 2.3 are incompatible with cucumber 1.x where there's no cucumber versions that runs on all ruby versions we support. It makes me think we might want to explore upgrading to cucumber 2.x for the ruby versions that can run it. Is it easy to have feature files and step definitions that work on cucumber 1.x and 2.x at the same time?

@mattwynne
Copy link
Member Author

myronmarston commented on Aug 12

Is it easy to have feature files and step definitions that work on cucumber 1.x and 2.x at the same time?

Yes, our intent with 2.0 was that it remained completely backwards compatible. I'd expect the step definitions to remain so for quite a few major versions - it's more the "semi-internal" APIs that we're tidying up, making things more modular / plug-able. Remember that thing we broke in one of VCR's Before hooks for example. That kind of thing.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants