-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Ruby v1.9.3 #993
Conversation
We have to find a way to filer out the " |
@brasmusson I realised after I merged this that you'd also removed the other Rubies (2.0, 2.1, 2.2) from the build matrix. Was that deliberate? Are we assuming that testing 2.3 covers them all? Or should we add them back? |
@mattwynne If you look at the list of commits, you will see "Try and fix JRuby error on Travis" twice and both times the build failed. When trying to fix JRuby I removed almost all other builds from the matrix to not waste computing power, but since I did not finally successfully fixed the JRuby build, I had not cleaned up this PR. What I really wanted say with my comment on #1009, was "yep, I have also run into the |
- jruby-1.7.12 | ||
matrix: | ||
include: | ||
- rvm: 2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 2.3.1 or just 2.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously just 2.3 did not work on Travis d688d88.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Remove support for Ruby v1.9.3. Closes #902.
Details
Remove Ruby v1.9.3 from the Travis matrix. Remove the backport of Hash({...}).