Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Ruby v1.9.3 #993

Merged
merged 7 commits into from
Aug 19, 2016
Merged

Remove support for Ruby v1.9.3 #993

merged 7 commits into from
Aug 19, 2016

Conversation

brasmusson
Copy link
Contributor

Summary

Remove support for Ruby v1.9.3. Closes #902.

Details

Remove Ruby v1.9.3 from the Travis matrix. Remove the backport of Hash({...}).

@brasmusson brasmusson added this to the 3.0 milestone Jul 3, 2016
@brasmusson
Copy link
Contributor Author

We have to find a way to filer out the "jruby: warning: unknown property jruby.cext.enabled" warnings that the non v1.9.3 JRubies prints on Travis, a problem that also surfaces for the Gherkin project.

@brasmusson brasmusson mentioned this pull request Aug 19, 2016
6 tasks
@mattwynne mattwynne merged commit b1741f9 into master Aug 19, 2016
@mattwynne
Copy link
Member

@brasmusson I realised after I merged this that you'd also removed the other Rubies (2.0, 2.1, 2.2) from the build matrix. Was that deliberate? Are we assuming that testing 2.3 covers them all? Or should we add them back?

@brasmusson
Copy link
Contributor Author

@mattwynne If you look at the list of commits, you will see "Try and fix JRuby error on Travis" twice and both times the build failed. When trying to fix JRuby I removed almost all other builds from the matrix to not waste computing power, but since I did not finally successfully fixed the JRuby build, I had not cleaned up this PR. What I really wanted say with my comment on #1009, was "yep, I have also run into the unknown property jruby.cext.enabled, and I worked on them here, but as you can see, I did not manage to get the JRuby build completely passed before I gave up."

- jruby-1.7.12
matrix:
include:
- rvm: 2.3.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 2.3.1 or just 2.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously just 2.3 did not work on Travis d688d88.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mattwynne added a commit that referenced this pull request Aug 19, 2016
@brasmusson brasmusson deleted the remove-ruby-1.9.3 branch September 29, 2018 11:08
@lock
Copy link

lock bot commented Sep 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Ruby 1.9.3 and below
3 participants