Fixes rubocop violation Performance/StringReplacement

[pmatsinopoulos]

Summary

Fixes rubocop violation Performance/StringReplacement

Details

Changes to stop using .gsub() to do character replacements, but use ,tr() instead. Also, when
.gsub() was used to delete a character, we are now using .delete().

Motivation and Context

This change makes sure our code is compliant with the ruboxop Performance/StringReplacemenet rule

Refs #1021

How Has This Been Tested?

I have run all the tests with bundle exec rake and everything is green. Rubocop is happy too.

Screenshots (if appropriate):

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Performance improvements

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[nodo]

Hi @pmatsinopoulos , thanks again for your effort. Please, could you rebase the PR?

[pmatsinopoulos]

@nodo I just did the rebase.

[nodo]

Thanks @pmatsinopoulos ! 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.