Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax filter for "/usr/local/ruby-X.Y.Z/bin/bundle". #1079

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Feb 14, 2017

Summary

This fixes tests with /usr/local/ruby-X.Y.Z/bin/bundle.
The solution is mentioned by #1069 (comment)
Can you check this PR before #1077 ?

Details

Motivation and Context

Want to pass tests.

How Has This Been Tested?

There is still an error. but it is another reason.

$ ruby -v
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]

$ bundle -v
Bundler version 1.14.3

$ bundle exec rake spec
...
568 examples, 0 failures

$ bundle exec rake cucumber
...
(::) failed steps (::)

expected "No such file or directory @ rb_sysopen - features. You can use `cucumber --init` to get started.\n" to include "No such file or directory - features. You can use `cucumber --init` to get started."
Diff:
@@ -1,2 +1,2 @@
-No such file or directory - features. You can use `cucumber --init` to get started.
+No such file or directory @ rb_sysopen - features. You can use `cucumber --init` to get started.
 (RSpec::Expectations::ExpectationNotMetError)
features/docs/getting_started.feature:10:in `Then it should fail with:'

Failing Scenarios:
cucumber features/docs/getting_started.feature:7 # Scenario: Run Cucumber in an empty directory

207 scenarios (1 failed, 206 passed)
1217 steps (1 failed, 1216 passed)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@nodo
Copy link
Member

nodo commented Feb 15, 2017

Thanks for nicely split the PRs @junaruga. Great stuff!

@nodo nodo merged commit 3bdfc7c into cucumber:master Feb 15, 2017
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants