Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_run_starting event to broadcast all test cases before a run #1082

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

mattwynne
Copy link
Member

@mattwynne mattwynne commented Feb 15, 2017

Any listener that wants to know how many test cases there will be (e.g. to display a progress bar) will need this information.

@mattwynne mattwynne changed the title Add event to broadcast all test cases Add test_run_starting event to broadcast all test cases before a run Feb 15, 2017
@mattwynne
Copy link
Member Author

Part of #962

@brasmusson
Copy link
Contributor

Is it really a good idea that because one listener needs to know the number test cases, also when that listener is not used, the first test case cannot be executed before all feature files have been parsed and compiled? Isn't this a major change from the original design of "the new core". Shouldn't this be subject of a command line option?

@@ -32,6 +32,7 @@ def self.registry
StepActivated,
TestRunFinished,
GherkinSourceRead
TestRunStarting,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma seems to be misplaced?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brasmusson
Copy link
Contributor

Also I think that an event named "TestRunStarting" should be issued first before any feature files has been read, and that the time printed in the summary should be the time difference between the time stamp of the TestRunStaring event and the time stamp of the TestRunFinished event.

@mattwynne
Copy link
Member Author

now you tell me 😜

@brassmusson good point. maybe we could be clever enough to only add this filter if there is anyone listening to the event?

@olleolleolle olleolleolle mentioned this pull request Jun 22, 2017
6 tasks
olleolleolle added a commit that referenced this pull request Jun 22, 2017
@mattwynne mattwynne deleted the add-before-rest-run-event branch July 7, 2017 20:46
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants