-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_run_starting
event to broadcast all test cases before a run
#1082
Conversation
082dc25
to
d545a5e
Compare
test_run_starting
event to broadcast all test cases before a run
Part of #962 |
d545a5e
to
e9e9c00
Compare
Is it really a good idea that because one listener needs to know the number test cases, also when that listener is not used, the first test case cannot be executed before all feature files have been parsed and compiled? Isn't this a major change from the original design of "the new core". Shouldn't this be subject of a command line option? |
@@ -32,6 +32,7 @@ def self.registry | |||
StepActivated, | |||
TestRunFinished, | |||
GherkinSourceRead | |||
TestRunStarting, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma seems to be misplaced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think that an event named "TestRunStarting" should be issued first before any feature files has been read, and that the time printed in the summary should be the time difference between the time stamp of the TestRunStaring event and the time stamp of the TestRunFinished event. |
now you tell me 😜 @brassmusson good point. maybe we could be clever enough to only add this filter if there is anyone listening to the event? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Any listener that wants to know how many test cases there will be (e.g. to display a progress bar) will need this information.