Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop offences 1021 002 #1095

Merged
merged 2 commits into from
Mar 29, 2017
Merged

Fix rubocop offences 1021 002 #1095

merged 2 commits into from
Mar 29, 2017

Conversation

bv
Copy link
Member

@bv bv commented Mar 22, 2017

Summary

Several fixes have been made for some of the RuboCop offenses reported.

Details

The Style/TrailingWhitespace style violations have been fixed whether completely or partially:

There are RoboCop's offenses reviewed but not fixed due to irrelevance, like trailing white spaces inside multi-line string literals in files:

  • spec/cucumber/formatter/pretty_spec.rb
  • spec/cucumber/formatter/progress_spec.rb

Another one offence has been fixed as well: Style/SpaceInsideStringInterpolation

Motivation and Context

There is bunch of exceptions for the code styling tool of RoboCop to be fixed.
Here is the main issue: #1021

How Has This Been Tested?

bundle exec rake produces no test failures

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Contributor

@danascheider danascheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes, @bv!

@danascheider danascheider merged commit bcd9481 into cucumber:master Mar 29, 2017
@bv bv deleted the fix-rubocop-offences-1021-002 branch March 29, 2017 19:08
@bv
Copy link
Member Author

bv commented Mar 29, 2017

@danascheider, thank you for taking care of the merge!

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants