Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the HTML Formatter #1306

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Remove the HTML Formatter #1306

merged 1 commit into from
Jul 16, 2018

Conversation

brasmusson
Copy link
Contributor

Summary

Remove the HTML Formatter.

Details

The HTML Formatter is removed to enable the removal of the legacy_api. The HTML Formatter is not expected to reappear until a shared binary HTML Formatter has been developed (see the #committers channel in slack and the discussion in #1230).

Motivation and Context

To enable the removal of the legacy_api, see #1230.

How Has This Been Tested?

The automated test suite has been updated to work without the HTML Formatter.

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@@ -9,9 +9,9 @@ module Cucumber
include Constantize

it 'loads html formatter' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to pretty

@brasmusson brasmusson merged commit 77ae250 into master Jul 16, 2018
brasmusson added a commit that referenced this pull request Jul 16, 2018
brasmusson added a commit that referenced this pull request Jul 16, 2018
@brasmusson brasmusson deleted the remove-html-formatter branch July 16, 2018 11:35
@lock
Copy link

lock bot commented Jul 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants