Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion for slightly cleaner regexps #237

Merged
merged 1 commit into from
Mar 4, 2012
Merged

suggestion for slightly cleaner regexps #237

merged 1 commit into from
Mar 4, 2012

Commits on Feb 27, 2012

  1. emit readable, more concise /"(.*?)"/ rather than /"([^"]*)"/ 

    I suggested this change while reviewing a cucumber-using project:
  - Given /^"([^"]*)" instance's provider is not accessible$/ do |arg1|
  + Given /^"(.*?)" instance's provider is not accessible$/ do |arg1|
since the use of non-greedy .*? is equivalent and more readable.
Then I learned that these were based on suggestions from cucumber,
so now I'm suggesting the improvement here.
    Jim Meyering committed Feb 27, 2012
    Configuration menu
    Copy the full SHA
    af4625c View commit details
    Browse the repository at this point in the history