Html formatter failing with undefined steps

[robertodecurnex]

Having an scenario outline with undefined steps, and using the --expand option cause the html formatter to fail.

undefined method `actual_keyword' for #<Cucumber::Ast::Step:0x96985e4> (NoMethodError)

Turns out that after_step_result is called for every Cucumber::Ast::StepInvocationand every Cucumber::Ast::Step. While the former support the actual_keyword method the later does not.

The change will make use of the actual_keyword, only of the step class supports it, and default to the keyword, that comes as a param, if not.

---

 Feature:

    Scenario Outline:
      Given an undefined step

    Examples:
      |foo|
      |bar|

$ cucumber --format html --expand

undefined method actual_keyword' for #Cucumber::Ast::Step:0x8b29f78 (NoMethodError)`

[mattwynne]

Thanks for your contribution! Could you please add a test for this behaviour?

The specs for the HTML formatter are good, it should be pretty easy to reproduce this bug in there.

[robertodecurnex]

Yup, sorry, I'm already working on them.
It took me some time to find how to activate the expand flag from there :p

[robertodecurnex]

A cuke has been added.

Specs, like the rest of the html formatter tests, can not be added since the formatter doesn't handle the --expand option.

The specs for the HTML formatter do not cover options at all actually.

[os97673]

I think you do not have to test option in spec you could just test that after_step_result() doesn't raise
an exception been called with a step which doesn't support actual_keyword.

[os97673]

I've merged the PR as is, though spec for the problem is always welcome (btw it would be nice to have such spec for all formatters)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.