Rewrite the Progress, Usage, Stepdefs formatters to the new formatter api #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some deficiencies of the Progress formatter are fixed, both that outline steps were printed as skipped, and some cases where the printed progress characters did not match the step count in the summary.
|
WOW! Thanks @brasmusson, you absolute champ. Looking forward to reading through this one and getting it merged. Well done! |
mattwynne
added a commit
that referenced
this pull request
Jun 19, 2015
Rewrite the Progress, Usage, Stepdefs formatters to the new formatter api
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these formatters are related through inheritance they are modified together. Since the Stepdef formatter neither defined any method of the old formatter api, nor defines any methods of the new formatter api, it is updated to the new formatter api by the changes in the Progress and Usage formatters.
Also some deficiencies of the Progress formatter are fixed, both that outline steps were printed as skipped (fixes #316), and some cases where the printed progress characters did not match the step count in the summary (here only 8 '-' were printed, but the step count says 11 skipped).
Related to #839.