Change the Progress, Usage and Stepdef formatter use events #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module Events | ||
|
|
||
| # Event fired after each step definition has been loaded | ||
| class StepDefinitionLoaded |
There was a problem hiding this comment.
I think I like "registered" better than "loaded". WDYT?
There was a problem hiding this comment.
Considering that the event is fired in the method register_rb_step_definition, you are absolutely right.
|
Great work @brasmusson! I like the use of the new event - I'd been thinking along the same lines, and it's great to see the code for real 👍 |
7 tasks
brasmusson
force-pushed
the
progress-formatter-use-events
branch
from
fbc50ab
to
8688879
Compare
|
Rebased on top of the (merged) move of events infrastructure to the core. |
Then a listener to the event bus can find out which step definitions were not matched to any step.
Also change Progress, Usage and Stepdef formatter to use the new initialize method signature. The API:s of Cucumber::Formatter::Console and Cucumber::Formatter::Summary are extended, but are backward compatible as they are use both by the Pretty formatter and existing custom formatters.
brasmusson
force-pushed
the
progress-formatter-use-events
branch
from
8688879
to
eb275bf
Compare
richarda
pushed a commit
to richarda/cucumber
that referenced
this pull request
Jul 1, 2016
…#977) * Add the StepDefinitionRegistered event. Then a listener to the event bus can find out which step definitions were not matched to any step. * Change the Progress, Usage and Stepdef formatter to use events. Also change Progress, Usage and Stepdef formatter to use the new initialize method signature. The API:s of Cucumber::Formatter::Console and Cucumber::Formatter::Summary are extended, but are backward compatible as they are use both by the Pretty formatter and existing custom formatters.
This was referenced Nov 24, 2016
2 tasks
mattwynne
added a commit
that referenced
this pull request
Jun 24, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Progress, Usage and Stepdef formatter use events and also the new initialize method signature.
For the Usage formatter to be able to find out which step definitions that were not matched to any step, the StepDefinitionLoaded event is added. This also means that the step definitions are loaded after the AfterConfigurationHooks have been executed and the formatter have been created, whereas the support files are loaded before the AfterConfigurationHooks are executed.
The API:s of Cucumber::Formatter::Console and Cucumber::Formatter::Summary are extended, but are backward compatible as they are use both by the Pretty formatter and existing custom formatters.
To simplify the usage of Cucumber::Core::Test::Result::Summary its API has been extended in cucumber/cucumber-ruby-core@e7fb8b7 (already on master of Cucumber-Ruby-Core).