Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Adopt c# 12 primary constructors #272

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Aug 16, 2024

🤔 What's changed?

⚡️ What's your motivation?

Adopt modern c# language feature to simplify code base

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

no changes in product. code style changes only

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@Romfos Romfos marked this pull request as ready for review August 16, 2024 19:24
@luke-hill
Copy link
Contributor

@Romfos - Given the breaking changes that have already gone in for .NET does it make sense to get these in too so there's just one large changeset for .NET as the next version (v30)? Or should this go in as a separate change?

@Romfos
Copy link
Contributor Author

Romfos commented Aug 23, 2024

@luke-hill As you wish.
I'm planning to create several next PR's after this.
This is not a blocker for release. You can release it any time at current state or wait full change set.
After ever PR all test are green and lib is ready for release

@luke-hill
Copy link
Contributor

@Romfos - What I meant is if you're doing a few breaking changes for .NET it makes sense to get them all in one go as the major version will change for all flavours of gherkin

Given the next version is already a major, any / all new breaking changes you can get in soon makes it easier for us

@Romfos
Copy link
Contributor Author

Romfos commented Aug 26, 2024

@luke-hill got it. Some low impactful but breaking changes are expected

Please assist me me with code review

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge this probably tomorrow.

@luke-hill while it's good to bundle big but non-breaking changes, it is not essential. With half a dozen languages in one project we'll always have a few people working in parallel. That will create some contention. So it is better to have regular releases to keep the momentum.

Breaking changes however are good to group together.

@mpkorstanje
Copy link
Contributor

@Romfos my and other maintainers availability is intermittent. And for some changes we'll have to reach out to people with more .Net knowledge. This makes the process a bit slow. Especially with the current batch size.

So far your changes have been well defined, narrowly scoped and non-breaking. And it looks like you are doing general maintenance so I assume there will be more like it.

Would you be okay with bundeling all future changes that meet these criteria as a single PR with each commit being a what is now a PR?

Should we find anything controversial we can merge the non controversial commits and work out the problematic parts separately.

@Romfos
Copy link
Contributor Author

Romfos commented Aug 27, 2024

@mpkorstanje okay. I will do it for the next PR

no need to rush, please review when you will have a time

@mpkorstanje mpkorstanje merged commit 607a142 into cucumber:main Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants