Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Enable markdown acceptance tests #37

Closed
wants to merge 1 commit into from

Conversation

mpkorstanje
Copy link
Contributor

Follow up for cucumber/common#2103

@mpkorstanje
Copy link
Contributor Author

mpkorstanje commented Nov 8, 2022

@temyers looks like we missed a few things when enabling the acceptance tests.

You will at the very least have to fix gherkin_generate_tokens.py to handle markdown files. And you may also have to generate some acceptance tests data. I was working on the assumption that the Javascript implementation had included these already (I was wrong, #36).

Also, since you've had an PR merged, please feel free to use this branch and project directly.

@mpkorstanje mpkorstanje mentioned this pull request Nov 8, 2022
71 tasks
@mpkorstanje mpkorstanje force-pushed the python-enable-markdown-acceptance-tests branch from 24957b0 to e5dad4c Compare November 8, 2022 15:08
@temyers
Copy link
Contributor

temyers commented Nov 9, 2022

Dang, ok I'll try and have a look.

Interesting that this wasn't picked up during the original merge? looking at the referenced issue, they were disabled?

@mpkorstanje
Copy link
Contributor Author

Interesting that this wasn't picked up during the original merge?

We didn't sufficiently enable them. There was another subtle difference between the make files (other than the linked issue) that meant that only feature files would be used in the acceptance tests.

I was also in a bit of a hurry to get the MR merged. 😅

@temyers
Copy link
Contributor

temyers commented Nov 28, 2022

@mpkorstanje Please see: #64
I've started making changes there. Still WIP.

Worth moving any discussion under that PR?

@mpkorstanje
Copy link
Contributor Author

I am happy to let it supercede this one.

@mpkorstanje mpkorstanje deleted the python-enable-markdown-acceptance-tests branch December 17, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants