Upgrade go from 1.16 ?

[Johnlon]

@vearutop
@mpkorstanje

Any reason why we need to stick on 1.16?

I want to use generics internally and need 1.18 and a bunch of basic utilities are missing in our ancient 1.16.

Summary ...
1.16 Feb 2021 - is ancient history
1.19 Aug 2022 - upgrade to this at least, utilities libs, generics
1.20 Feb 2023 - adds potentially useful conversions
1.21 Aug 2023 - adds potentially useful type inference
1.22 Feb 2024 - improved for loops, linter improvements
1.23 Aug 2024 - improved iterators

[vearutop]

That's a good point, I've moved required status checks to stable/oldstable Go versions. I think we can remove 1.16 and 1.17 from CI.

[Johnlon]

Does that mean I can change go.mod to 1.22?

[Johnlon]

or 1.23?

[vearutop]

Let's bump it to what's needed? E.g. if you want generics in the godog itself (not talking about the users of the library), that'd be 1.18.

Bumping too high can be an unpleasant upgrade demand to those who lag behind. I think it is generally a good idea to keep backwards compatibility when that's feasible and doesn't incur high maintenance costs.

[Johnlon]

some basic API missing too on syrings and sort and slice

…

On Mon, 4 Nov 2024, 4:46 pm Viacheslav Poturaev, ***@***.***> wrote: Let's bump it to what's needed? E.g. if you want generics in the godog itself (not talking about the users of the library), that'd be 1.18. Bumping too high can be an unpleasant upgrade demand to those who lag behind. I think it is generally a good idea to keep backwards compatibility when that's feasible and doesn't incur high maintenance costs. — Reply to this email directly, view it on GitHub <#660 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMFGAZ5BDVTOIOYHOO5EDZ66QGHAVCNFSM6AAAAABQ6AQKZWVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMJUGUYDGNI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Johnlon]

2 years out of date is probably a cut off I think. (IE 1.19)

I'll see what cuts the mustard.

-++

btw the old honnef we use 0.4.6 crashes on my 1.22 install (or is it 1.23?) so upgrading to 0.5.1 fixed that build issue but won't work on 1.16