Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DONT MERGE YET - REVIEW COMMENTS PLEASE - Test renovation - in preparation for fixing the Hook handler bug and adding other features. #659

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

DONT MERGE YET - REVIEW COMMENTS PLEASE - Test renovation - in preparation for fixing the Hook handler bug and adding other features. #659

wants to merge 17 commits into from

Commits on Oct 24, 2024

  1. - moved all the tests from suite_context_test.go that do NOT rely on … 

    …"features" and it's massive set of steps into run_test

- removed some duplicate tests from example_subtests_test.go
    @Johnlon
    Johnlon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bacc276 View commit details
    Browse the repository at this point in the history

  2. typo

    @Johnlon
    Johnlon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    92fcacb View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. renovated the tests so that they use the Public api of the product. 

    Previously the suite_context_tests weren't actually testing godog at all but an exploded version of what the internal code might have looked like at some point in the past.
Removed some junk test cases around events.feature that weren't actually testing godog but some irrelevant stuff in the exploded code.
    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9a293b3 View commit details
    Browse the repository at this point in the history

  2. additional output files for hook_errors

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7c2e3a9 View commit details
    Browse the repository at this point in the history

  3. feature_test

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    10d581b View commit details
    Browse the repository at this point in the history

  4. feature_test clean up

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    887b181 View commit details
    Browse the repository at this point in the history

  5. fixme fixed and remove john tags

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    61aea3e View commit details
    Browse the repository at this point in the history

  6. added embiguous steps tests to run.feature

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    19489aa View commit details
    Browse the repository at this point in the history

  7. typos

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dcf0fea View commit details
    Browse the repository at this point in the history

  8. provide a run method that returns the storage so that we can run test… 

    …s on it or do whatever the end user wants

make honnef scan whole tree
    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    547f429 View commit details
    Browse the repository at this point in the history

  9. fixed a broken test suite Test_FormatterConcurrencyRun

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    46d4b2a View commit details
    Browse the repository at this point in the history

  10. remove dependency

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    64026b6 View commit details
    Browse the repository at this point in the history

  11. makefile now does same check as github - ie it checks the examples

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5b02745 View commit details
    Browse the repository at this point in the history

  12. remove @ignore

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9a1e216 View commit details
    Browse the repository at this point in the history

  13. Change clitest to 

    go run ./cmd/godog -f progress -c 4 --strict
.. because thats what github does
    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dc237f9 View commit details
    Browse the repository at this point in the history

  14. cleanup

    @Johnlon
    Johnlon committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    535c3c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. adding missing steps

    @Johnlon
    Johnlon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b35a48b View commit details
    Browse the repository at this point in the history