Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tree-sitter logic to language-service #28

Closed
aslakhellesoy opened this issue Feb 3, 2022 · 1 comment
Closed

Move tree-sitter logic to language-service #28

aslakhellesoy opened this issue Feb 3, 2022 · 1 comment

Comments

@aslakhellesoy
Copy link
Contributor

aslakhellesoy commented Feb 3, 2022 •
edited
Loading

The @cucumber/monaco module needs the tree-sitter functionality, but not the @cucumber/language-server functionality. Since @cucumber/monaco depends on @cucumber/language-service, we should move the tree-sitter functionality there.

It used to be in @cucumber/language-service, but it was removed in 0.10.0. Let's undo that.
@aslakhellesoy aslakhellesoy mentioned this issue Feb 3, 2022
Closed
@olleolleolle
Copy link
Contributor

Thanks for the analysis on these issues, it shakes loose a few things! Context matters.

This was referenced Feb 3, 2022
Closed
Merged
@aslakhellesoy aslakhellesoy mentioned this issue Feb 4, 2022
Merged
aslakhellesoy added a commit that referenced this issue Feb 5, 2022
@aslakhellesoy
Merge pull request #29 from cucumber/28-move-tree-sitter
3cefe0c 
Move wasm to language-service. Fixes #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olleolleolle @aslakhellesoy