Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export custom node and wasm entry points #39

Merged
merged 2 commits into from
Apr 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Added
- Support for C#
- Support for PHP

### Changed
- Remove external dependency on `@cucumber/language-service` - always use tree-sitter wasm

## [0.6.0] - 2022-04-26
### Changed
- Use tree-sitter Node.js bindings instead of web (WASM) bindings.
Expand Down
5 changes: 2 additions & 3 deletions bin/cucumber-language-server.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env node
require('source-map-support').install()
const { startServer } = require('../dist/cjs/src/startServer')
const { NodeParserAdapter } = require('@cucumber/language-service/node')
startServer(new NodeParserAdapter())
const { startNodeServer } = require('../dist/cjs/src/node/startNodeServer')
startNodeServer()
7 changes: 7 additions & 0 deletions node/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "wasm",
"description": "Cucumber Language server using tree-sitter node bindings",
"main": "../dist/cjs/src/node/startNodeServer.js",
"module": "../dist/esm/src/node/startNodeServer.js",
"types": "../dist/esm/src/node/startNodeServer.d.ts"
}
33 changes: 26 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 14 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,25 @@
"version": "0.6.0",
"description": "Cucumber Language Server",
"type": "module",
"main": "dist/cjs/src/index.js",
"module": "dist/esm/src/index.js",
"types": "dist/esm/src/index.d.ts",
"main": "dist/cjs/src/node/startNodeServer.js",
"module": "dist/esm/src/node/startNodeServer.js",
"types": "dist/esm/src/node/startNodeServer.d.ts",
"exports": {
".": {
"import": "./dist/esm/src/index.js",
"require": "./dist/cjs/src/index.js"
"import": "./dist/esm/src/node/startNodeServer.js",
"require": "./dist/cjs/src/node/startNodeServer.js"
},
"./wasm": {
"import": "./dist/esm/src/wasm/startWasmServer.js",
"require": "./dist/cjs/src/wasm/startWasmServer.js"
}
},
"files": [
"dist/cjs/src",
"dist/esm/src"
"dist/cjs/package.json",
"dist/esm/src",
"node",
"wasm"
],
"bin": {
"cucumber-language-server": "bin/cucumber-language-server.cjs"
Expand Down Expand Up @@ -77,7 +84,7 @@
"dependencies": {
"@cucumber/cucumber-expressions": "^15.1.1",
"@cucumber/gherkin-utils": "^7.0.0",
"@cucumber/language-service": "^0.14.4",
"@cucumber/language-service": "^0.15.0",
"fast-glob": "3.2.11",
"source-map-support": "0.5.21",
"vscode-languageserver": "7.0.0",
Expand Down
10 changes: 6 additions & 4 deletions src/CucumberLanguageServer.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Expression, ParameterTypeRegistry } from '@cucumber/cucumber-expressions'
import {
buildSuggestions,
ExpressionBuilder,
getGherkinCompletionItems,
getGherkinDiagnostics,
getGherkinFormattingEdits,
Expand All @@ -11,7 +12,6 @@ import {
semanticTokenTypes,
Suggestion,
} from '@cucumber/language-service'
import { ExpressionBuilder } from '@cucumber/language-service'
import {
ConfigurationRequest,
Connection,
Expand Down Expand Up @@ -40,18 +40,20 @@ const defaultSettings: Settings = {
}

export class CucumberLanguageServer {
private readonly expressionBuilder
private readonly expressionBuilder: ExpressionBuilder
private searchIndex: Index
private expressions: readonly Expression[] = []
private reindexingTimeout: NodeJS.Timeout

constructor(
private parserAdapter: ParserAdapter,
private readonly connection: Connection,
private readonly documents: TextDocuments<TextDocument>
private readonly documents: TextDocuments<TextDocument>,
parserAdapter: ParserAdapter
) {
this.expressionBuilder = new ExpressionBuilder(parserAdapter)
connection.onInitialize(async (params) => {
await parserAdapter.init()

if (params.capabilities.workspace?.configuration) {
connection.onDidChangeConfiguration((params) => {
this.reindex(<Settings>params.settings).catch((err) => {
Expand Down
1 change: 0 additions & 1 deletion src/index.ts

This file was deleted.

4 changes: 3 additions & 1 deletion src/loadAll.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@ import fg from 'fast-glob'
import fs from 'fs/promises'
import path from 'path'

type Extension = '.ts' | '.java'
type Extension = '.ts' | '.java' | '.cs' | '.php'

export const languageByExt: Record<Extension, LanguageName> = {
'.ts': 'typescript',
'.java': 'java',
'.cs': 'c_sharp',
'.php': 'php',
}

const extensions = Array.from(Object.keys(languageByExt)).concat('.feature')
Expand Down
7 changes: 7 additions & 0 deletions src/node/startNodeServer.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { NodeParserAdapter } from '@cucumber/language-service/node'

import { startServer } from '../startServer'

export function startNodeServer() {
startServer(new NodeParserAdapter())
}
2 changes: 1 addition & 1 deletion src/startServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { CucumberLanguageServer } from './CucumberLanguageServer.js'
export function startServer(adapter: ParserAdapter) {
const connection = createConnection(ProposedFeatures.all)
const documents = new TextDocuments(TextDocument)
new CucumberLanguageServer(adapter, connection, documents)
new CucumberLanguageServer(connection, documents, adapter)
connection.listen()

// Don't die on unhandled Promise rejections
Expand Down
7 changes: 7 additions & 0 deletions src/wasm/startWasmServer.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { WasmParserAdapter } from '@cucumber/language-service/wasm'

import { startServer } from '../startServer'

export function startWasmServer(wasmBaseUrl: string) {
startServer(new WasmParserAdapter(wasmBaseUrl))
}
2 changes: 1 addition & 1 deletion test/CucumberLanguageServer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('CucumberLanguageServer', () => {
serverConnection = createConnection(inputStream, outputStream)
documents = new TextDocuments(TextDocument)

new CucumberLanguageServer(new NodeParserAdapter(), serverConnection, documents)
new CucumberLanguageServer(serverConnection, documents, new NodeParserAdapter())
serverConnection.listen()

const initializeParams: InitializeParams = {
Expand Down
6 changes: 3 additions & 3 deletions tsconfig.build-cjs.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": "./tsconfig.build.json",
"compilerOptions": {
"outDir": "dist/cjs",
"target": "ES5",
"target": "ES6",
"module": "CommonJS",
},
"outDir": "dist/cjs"
}
}
7 changes: 7 additions & 0 deletions wasm/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "wasm",
"description": "Cucumber Language server using tree-sitter wasm bindings",
"main": "../dist/cjs/src/wasm/startWasmServer.js",
"module": "../dist/esm/src/wasm/startWasmServer.js",
"types": "../dist/esm/src/wasm/startWasmServer.d.ts"
}