Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standalone startup (hopefully) #68

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix standalone startup (hopefully) #68

merged 1 commit into from
Oct 10, 2022

Conversation

aslakhellesoy
Copy link
Contributor

🤔 What's changed?

The standalone startup script (hopefully) works

⚡️ What's your motivation?

Fix #66

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

@darrinholst can you please confirm that 1.1.0 works and that it really fixes #66?
I wish I knew an automated way to fix this.

What I have in mind is something like cat some-rpc-file | cat node bin/cucumber-language-server.cjs --stdio and verify that we get some kind of OK response.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy aslakhellesoy marked this pull request as ready for review October 10, 2022 21:03
@aslakhellesoy aslakhellesoy merged commit b5927d3 into main Oct 10, 2022
@aslakhellesoy aslakhellesoy deleted the fix-standalone branch October 10, 2022 21:03
@aslakhellesoy aslakhellesoy restored the fix-standalone branch October 10, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get working with neovim
1 participant