Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob paths not matching c-sharp files #89

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Nov 16, 2023

The default glob paths for c-sharp step definition and feature files match the names that contain only the file extension (no stem) - e.g. complete filenames called .cs and .feature - thus must be configured by the user in all cases at present.

{
  features: [
     ...
     '*specs*/**/.feature',
   ],
   glue: [
     ...
     '*specs*/**/.cs',
  ]
}

🤔 What's changed?

  • Updated SpecFlow glob paths to match c-sharp file extensions
  • Reordered comments for Behave and Behat to ensure they label their respective glob patterns appropriately
{
  features: [
     ...
     '*specs*/**/*.feature',
   ],
   glue: [
     ...
     '*specs*/**/*.cs',
  ]
}

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@kieran-ryan kieran-ryan added the c_sharp Changes relating to C Sharp label Nov 16, 2023
@kieran-ryan kieran-ryan self-assigned this Nov 16, 2023
@kieran-ryan kieran-ryan marked this pull request as ready for review November 16, 2023 00:08
@kieran-ryan
Copy link
Member Author

kieran-ryan commented Dec 20, 2023

Issue was previously resolved within the VSCode extension (cucumber/vscode#93). However, as it was never updated in the Language Server first, when the list of glob patterns was extended for new languages within this repository, they were also applied back into the VSCode repo (following documented procedure) and included the previous patterns for C# - inadvertently reverting the fix.

Once this fix is merged, will update the changes within the VSCode extension.

@mpkorstanje mpkorstanje merged commit d71ef6e into cucumber:main Dec 20, 2023
5 checks passed
kieran-ryan added a commit to kieran-ryan/vscode that referenced this pull request Dec 21, 2023
kieran-ryan added a commit to cucumber/vscode that referenced this pull request Dec 21, 2023
* Fix glue for csharp steps

* Fix changelog file

* Align C# config with language server

See Language Server PR: cucumber/language-server#89

---------

Co-authored-by: Kieran Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c_sharp Changes relating to C Sharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants