-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript Support - Addresses #42 #115
Conversation
Thanks for contributing this! I'll have more feedback when I've done a thorough review, but at first glance this looks great. |
Hi @aslakhellesoy following up to check on the feedback |
Hi @rvramesh, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Thank you for accepting the PR and the kind words |
🤔 What's changed?
Adds support for JavaScript
⚡️ What's your motivation?
Fixes #42
After the review, will update the document, changelog and https://github.com/cucumber/vscode/blob/main/README.md
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The
tree-sitter-javascript
was not working well. Hence usingtree-sitter-typescript
with jsx support for JavaScript as well as TS grammar is super set of JavaScript. Kindly provide feedback.📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.