Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Support - Addresses #42 #115

Merged
merged 9 commits into from
Dec 8, 2022

Conversation

rvramesh
Copy link
Contributor

@rvramesh rvramesh commented Nov 26, 2022

🤔 What's changed?

Adds support for JavaScript

⚡️ What's your motivation?

Fixes #42

After the review, will update the document, changelog and https://github.com/cucumber/vscode/blob/main/README.md

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

The tree-sitter-javascript was not working well. Hence using tree-sitter-typescript with jsx support for JavaScript as well as TS grammar is super set of JavaScript. Kindly provide feedback.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@rvramesh rvramesh marked this pull request as ready for review November 26, 2022 12:17
@rvramesh rvramesh changed the title JavaScript Support - Address #42 JavaScript Support - Addresses #42 Nov 26, 2022
@aslakhellesoy
Copy link
Contributor

Thanks for contributing this! I'll have more feedback when I've done a thorough review, but at first glance this looks great.

@rvramesh
Copy link
Contributor Author

rvramesh commented Dec 7, 2022

Thanks for contributing this! I'll have more feedback when I've done a thorough review, but at first glance this looks great.

Hi @aslakhellesoy following up to check on the feedback

@aslakhellesoy aslakhellesoy mentioned this pull request Dec 8, 2022
7 tasks
@aslakhellesoy aslakhellesoy merged commit 0e8f6e7 into cucumber:main Dec 8, 2022
@aslakhellesoy
Copy link
Contributor

Hi @rvramesh,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@rvramesh
Copy link
Contributor Author

rvramesh commented Dec 8, 2022

Hi @rvramesh,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

Thank you for accepting the PR and the kind words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JavaScript
2 participants